Update the CMakeList file for V 5.0.0#1287
Closed
lzjpaul wants to merge 1 commit intoapache:dev-postgresqlfrom
Closed
Update the CMakeList file for V 5.0.0#1287lzjpaul wants to merge 1 commit intoapache:dev-postgresqlfrom
lzjpaul wants to merge 1 commit intoapache:dev-postgresqlfrom
Conversation
Update the CMakeList file for V 5.0.0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-postgresql #1287 +/- ##
===============================================
Coverage 60.74% 60.74%
===============================================
Files 85 85
Lines 4524 4524
===============================================
Hits 2748 2748
Misses 1776 1776
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
need to update https://github.com/apache/singa/blob/master/setup.py#L86 as well? |
Contributor
Author
Yes, also need to update the setup.py, I create a new pull request. |
Contributor
Author
|
Create a new pull request to update the cmake and setup files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the CMakeList file for V 5.0.0